Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add ASN metric to opt-in server usage report #1610

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 16, 2024

I accidentally merged #1550 which was merging into another branch I had to abandon.

This one's properly going into master. Please take another look.

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some smalle comments.

src/shadowbox/server/shared_metrics.spec.ts Outdated Show resolved Hide resolved
src/shadowbox/server/shared_metrics.spec.ts Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/S labels Oct 17, 2024
@sbruens sbruens merged commit 845c023 into master Oct 17, 2024
10 checks passed
@sbruens sbruens deleted the sbruens/optin-asn branch October 17, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants