Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not set the host address #217

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: do not set the host address #217

merged 1 commit into from
Oct 2, 2024

Conversation

sbruens
Copy link

@sbruens sbruens commented Sep 30, 2024

This was a regression introduced in #192, which was rolled out in outline-server v1.10.0 released last week and caused issues for users using machines with IPv6 disabled: Jigsaw-Code/outline-server#1601.

I'm unable to reproduce the issue itself when IPv6 is disabled on my corp or DigitalOcean machines, but that may be specific to those machines.

@sbruens sbruens requested a review from a team as a code owner September 30, 2024 22:32
Copy link

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we need to verify whether it will fix the issue. Probably we can also have some configuration that let the user explicitly specify the IP stack (v4 or v6).

@sbruens
Copy link
Author

sbruens commented Oct 1, 2024

LGTM. But we need to verify whether it will fix the issue.

Agreed, though I'm still unable to reproduce this issue, on a host machine or in a Docker container. I had wanted to replicate this in the outline-server integration test, but to no avail. I propose merging this change and, as you suggested offline, creating a new canary release that we could ask affected folks to test.

Probably we can also have some configuration that let the user explicitly specify the IP stack (v4 or v6).

The new service config allows this now at the outline-ss-server layer; the new configuration allows a full address specification, instead of just a port:

But we don't yet support this at the outline-server/Manager layer. I agree it would be nice to explicitly specify the stack there, but I'm also not sure it's totally necessary.

@sbruens sbruens merged commit d240aa1 into master Oct 2, 2024
5 checks passed
@sbruens sbruens deleted the sbruens/ipv4 branch October 2, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants