Skip to content

Commit

Permalink
[stable/mediawiki] Fix chart not being upgradable (helm#7826)
Browse files Browse the repository at this point in the history
* [stable/mediawiki] Fix chart not being upgradable

Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>

* Fix mediawiki label

Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
  • Loading branch information
javsalgar authored and Jnig committed Nov 13, 2018
1 parent 3619866 commit 714904b
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stable/mediawiki/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: mediawiki
version: 3.0.6
version: 4.0.0
appVersion: 1.31.0
description: Extremely powerful, scalable software and a feature-rich wiki implementation
that uses PHP to process and display data stored in a database.
Expand Down
12 changes: 12 additions & 0 deletions stable/mediawiki/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,15 @@ The [Bitnami MediaWiki](https://github.com/bitnami/bitnami-docker-mediawiki) ima

Persistent Volume Claims are used to keep the data across deployments. This is known to work in GCE, AWS, and minikube.
See the [Configuration](#configuration) section to configure the PVC or to disable persistence.

## Upgrading

### To 4.0.0

Backwards compatibility is not guaranteed unless you modify the labels used on the chart's deployments.
Use the workaround below to upgrade from versions previous to 4.0.0. The following example assumes that the release name is mediawiki:

```console
$ kubectl patch deployment mediawiki-mediawiki --type=json -p='[{"op": "remove", "path": "/spec/selector/matchLabels/chart"}]'
$ kubectl delete statefulset mediawiki-mariadb --cascade=false
```
4 changes: 4 additions & 0 deletions stable/mediawiki/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ metadata:
release: {{ .Release.Name | quote }}
heritage: {{ .Release.Service | quote }}
spec:
selector:
matchLabels:
app: {{ template "mediawiki.name" . }}
release: "{{ .Release.Name }}"
replicas: 1
template:
metadata:
Expand Down

0 comments on commit 714904b

Please sign in to comment.