Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: editor improvements #75

Merged
merged 5 commits into from
Dec 14, 2024
Merged

plugin: editor improvements #75

merged 5 commits into from
Dec 14, 2024

Conversation

JoepVanlier
Copy link
Owner

@JoepVanlier JoepVanlier commented Dec 13, 2024

Why this PR?

  • It brings partial syntax highlighting (multiline strings are still excluded for now)
  • It makes sure that the state is not forgotten on save.
  • It ensures that a coding bug isn't interpreted as a missing plugin.
  • Pop modals out of the UI.

@JoepVanlier JoepVanlier force-pushed the syntax_highlighting branch 4 times, most recently from 09bf074 to 596aa95 Compare December 14, 2024 00:27
it should only prompt to find it, if the error is due to a missing file, and not when it's a syntax error
we store the last filename such that a compilation error doesn't immediately get us into a state where we can't fix and resave it
@JoepVanlier JoepVanlier merged commit 0485e10 into master Dec 14, 2024
12 checks passed
@JoepVanlier JoepVanlier deleted the syntax_highlighting branch December 14, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant