fix: don't render divider inside heading

JohannesKaufmann · Jan 23, 2022 · 7a10c54 · 7a10c54
1 parent cad6dec
commit 7a10c54
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 3 deletions.
diff --git a/commonmark.go b/commonmark.go
@@ -346,6 +346,12 @@ var commonmark = []Rule{
 	{
 		Filter: []string{"hr"},
 		Replacement: func(content string, selec *goquery.Selection, opt *Options) *string {
+			// e.g. `## --- Heading` would look weird, so don't render a divider if inside a heading
+			insideHeading := selec.ParentsFiltered("h1,h2,h3,h4,h5,h6").Length() > 0
+			if insideHeading {
+				return String("")
+			}
+
 			text := "\n\n" + opt.HorizontalRule + "\n\n"
 			return &text
 		},

diff --git a/testdata/TestCommonmark/heading/goldmark.golden b/testdata/TestCommonmark/heading/goldmark.golden
@@ -20,3 +20,5 @@
 <h1>not title</h1>
 <p>not title
 \-\-\-</p>
+<h4>More posts from around the site:</h4>
+<h4>More posts from around the site:</h4>
diff --git a/testdata/TestCommonmark/heading/input.html b/testdata/TestCommonmark/heading/input.html
@@ -73,4 +73,12 @@ <h1>#hashtag</h1>
 <p>
 not title
 \-\-\-
-</p>
+</p>
+
+
+<!--heading with divider-->
+<h4><hr>More posts from around the site:</h4>
+<h4><span>
+    <hr>
+    More posts from around the site:
+<span></h4>
diff --git a/testdata/TestCommonmark/heading/output.atx.golden b/testdata/TestCommonmark/heading/output.atx.golden
@@ -36,4 +36,8 @@ not title
 =
 
 not title
-\\-\\-\\-
+\\-\\-\\-
+
+#### More posts from around the site:
+
+#### More posts from around the site:
diff --git a/testdata/TestCommonmark/heading/output.setext.golden b/testdata/TestCommonmark/heading/output.setext.golden
@@ -42,4 +42,8 @@ not title
 =
 
 not title
-\\-\\-\\-
+\\-\\-\\-
+
+#### More posts from around the site:
+
+#### More posts from around the site: