-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add country/pollutant CLI options to airbase all #40
Conversation
Ah nice, so the arguments act like filters on |
Yes, it restricts/focuses the download to only a few pollutant/countries
It should be faster to request multiple pollutant/countries at once than requesting them one by one, but I would guess that the difference is small. This is mostly an UI/UX update based on the feedback from my colleague putting the CLI in production. What do you think about consolidating the CLI sub-commands? |
Yes I think this sounds like a good idea. Let's indeed deprecate them for now and add the new API already, and then we can remove in 1.0 |
c4e07dc
to
06f65a9
Compare
I added added a new CLI sub-command I would like to add a short entry to the README and the docs about |
I added the CLI to the README. The docs need some updating after merging #41 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, thanks for updating the readme as well! Just a few quick questions but I think this looks pretty much good to go.
Co-authored-by: John Paton <john@johnpaton.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, as always!
At work we need to download all observations/sites for 6 different pollutants.
At the moment we invoke the CLI 6 times as follows:
after merging this PR we'll be able to write
It will also be possible to restrict the download to specific countries on the same CLI sub-command, e.g. downloading the same pollutants only for Norwegian, Danish and Finish sites
It might be possible to consolidate the other sub-commands (after a deprecation cycle), as their functionality is provided here.