Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Python 3.7 support and enforce Python 3.8+ codding standards #50

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

avaldebe
Copy link
Collaborator

@avaldebe avaldebe commented Jun 20, 2024

  • drop Python 3.7 support
  • enforce code standards for Python 3.8+ using ruff

@avaldebe avaldebe self-assigned this Jun 20, 2024
@avaldebe avaldebe marked this pull request as ready for review June 20, 2024 08:59
@avaldebe
Copy link
Collaborator Author

@JohnPaton I would like cut a new release (by creating a tag).

In this PR, I used ruff to update the coding standards to Python 3.8.
In principle ruff can be used as a replacement to black and isort.
Would you want to use ruff for linting and formatting?
or we keep relying on black and isort for formatting?
I could also remove ruff from pre-commit if you find it too much.

Also, is there anything else you would like to include on the new release?

@avaldebe avaldebe requested a review from JohnPaton June 20, 2024 10:46
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@JohnPaton JohnPaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@avaldebe avaldebe merged commit 6043d71 into JohnPaton:master Jun 26, 2024
10 checks passed
@avaldebe avaldebe deleted the drop-py37 branch June 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants