Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request URLs with custom header #58

Merged
merged 2 commits into from
Sep 3, 2024
Merged

request URLs with custom header #58

merged 2 commits into from
Sep 3, 2024

Conversation

avaldebe
Copy link
Collaborator

@avaldebe avaldebe commented Sep 2, 2024

fixes #57

@avaldebe avaldebe requested a review from JohnPaton September 2, 2024 14:56
@avaldebe avaldebe self-assigned this Sep 2, 2024
@avaldebe avaldebe marked this pull request as draft September 2, 2024 14:57
@avaldebe avaldebe marked this pull request as ready for review September 2, 2024 15:09
@avaldebe
Copy link
Collaborator Author

avaldebe commented Sep 2, 2024

@JohnPaton only 2 changes were needed to get the old API working:

  • using https on LINK_LIST_URL_TEMPLATE
  • add special headers when requesting csv links

Copy link
Owner

@JohnPaton JohnPaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's hope they don't change the token anytime soon.

@JohnPaton
Copy link
Owner

Let's merge this and release 0.8.1 right away, and then rebase #54 so that we can actually trust the test suite again

@avaldebe avaldebe merged commit 95a1378 into master Sep 3, 2024
19 checks passed
@avaldebe avaldebe deleted the request-token branch September 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data retrieval fails
2 participants