Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataset/BBQ data #609

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Dataset/BBQ data #609

merged 8 commits into from
Jul 14, 2023

Conversation

RakshitKhajuria
Copy link
Contributor

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@RakshitKhajuria RakshitKhajuria added the v2.1.0 Issue or request to be done in v2.1.0 release label Jul 10, 2023
@RakshitKhajuria RakshitKhajuria self-assigned this Jul 10, 2023
@RakshitKhajuria RakshitKhajuria marked this pull request as draft July 10, 2023 16:25
@RakshitKhajuria RakshitKhajuria marked this pull request as ready for review July 13, 2023 08:52
JulesBelveze
JulesBelveze approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking but change "Stricly, Do not" -> "Stricly, do not"

@JulesBelveze JulesBelveze merged commit 4eb9f11 into release/1.1.0 Jul 14, 2023
@JulesBelveze JulesBelveze deleted the dataset/BBQ branch July 14, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

Assignees

@RakshitKhajuria RakshitKhajuria

Labels
v2.1.0 Issue or request to be done in v2.1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RakshitKhajuria @JulesBelveze