Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many of the missing structs needed for using {get,set}_thread_status #12

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

CraftSpider
Copy link

  • I can revert the removal of the __ on x86_thread_state64_t, I went off of the fact that the structs are defined both with and without in the header, and that it adds a lot of unnecessary noise.
  • The bitflag types API may not be perfect, I just went with something that worked
  • This is still missing arm definitions, they can be added as another PR if desired

@JohnTitor
Copy link
Owner

Could you resolve merge conflicts? And it seems some structs' fields aren't marked as pub, is it intentional?

@CraftSpider
Copy link
Author

Given the new arm code also uses the underscores, I'm leaning towards reverting that change. I'll spend some time writing up the manual implementations for the long arrays also, to fix the 1.33 build.

@CraftSpider
Copy link
Author

Any other review requests for this? I'm not sure why the test failed, but it doesn't look immediately related. If it is, can I get a pointer in the right direction?

@JohnTitor JohnTitor force-pushed the thread-status-structs branch from 01dc2e2 to 2882ba3 Compare December 19, 2023 15:04
@JohnTitor
Copy link
Owner

Sorry for the delay!
The problem is that ctest2 uses old rustc's crates to parse and generate code.
Maybe there is an unsupported syntax (on older rustc) on the changes but I cannot find what it is 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants