Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time_value #25

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Add time_value #25

merged 5 commits into from
Jan 3, 2024

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Jun 20, 2023

@JohnTitor
Copy link
Owner

Sorry for the delay, could you check the failure on Xcode 13 and 14? It seems these versions cannot find the items.

@ldm0 ldm0 force-pushed the ldm_add_time_value branch from 9f97143 to 964dfe4 Compare December 24, 2023 20:05
@ldm0
Copy link
Contributor Author

ldm0 commented Dec 24, 2023

Fixed. Reason of the CI failure is that the generated C code in mach-test uses time_value rather than struct time_value, which can be fixed by adding time_value in mach-test's build script.

Copy link
Owner

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@JohnTitor JohnTitor merged commit 1764622 into JohnTitor:main Jan 3, 2024
9 checks passed
@ldm0 ldm0 deleted the ldm_add_time_value branch January 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants