Rename files

[johnjacobkenny]

• VSCode Version: 1.21.1
• OS Version: Windows 10
• Extension Version: 1.26.1
• System Language: en
• SVN Version: 1.9.7

Issue

After renaming versioned files from vs code explorer view, the old filename file shows up as missing and the new filename file as unversioned. Is it possible to hook into the explorer rename event and perform the corresponding svn command to indicate the rename?

Steps to Reproduce

1. Rename a versioned file in vs code explorer view

SVN Output

Paste here content of "View >> Output >> OUTPUT >> SVN"

Screenshots

[edgardmessias]

Not supported by VSCode at moment

See microsoft/vscode#24846 and microsoft/vscode#43768

[edgardmessias]

Note:
When file are renamed, the const fsWatcher = workspace.createFileSystemWatcher("**"); every run fsWatcher.onDidCreate first, with new URI, and after run fsWatcher.onDidDelete with old URI.

In the source of VSCode, work with create a new copy of object and delete the old.

[edgardmessias]

Maybe, we can create a class to listener files changes to detect rename, and prompt to user.

If true, we need rollback the rename and run svn rename

[edgardmessias]

API Proposed in VSCode 1.25: https://code.visualstudio.com/updates/v1_25#_local-rename-events

[JohnstonCode]

vscode.workspace.on[Will|Did]RenameFile was added in 1.41.0 https://code.visualstudio.com/updates/v1_41#_workspace-file-events

[alexdymov]

Any update on this? I also tried to set keyboard shortcut for "Rename with SVN" command but the rename command is not executing when I press the key. It only works when clicked from file explorer. Had to go back to Eclipse to perform some basic refactoring actions.

[rbyshko]

Is somebody working on this at the moment?

[JohnstonCode]

No, feel free to submit a PR

[hansWurst-creator]

@JohnstonCode This issue is bugging me a lot. I would be willing to work on it. Would you accept a pull request?