-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a collection of beauty fixes #121
Conversation
03f8b64
to
a9ff137
Compare
e189b3c
to
63f8d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I like that we are reusing the GridItem
for the TLDR now. 💪
I'm not entirely sure that we should increase the height of the code snippet image but rather we should make the code easier to read (take a new snapshot with increased font size for the code in the editor).
src/modules/pages/components/Website/HomePage/EtherBanner/EtherBanner.jsx
Show resolved
Hide resolved
@@ -8,6 +8,6 @@ | |||
|
|||
.image { | |||
margin-bottom: 0; | |||
max-height: 90%; | |||
max-height: 98%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @collinvine's request for this to be larger was more along the lines of the code itself being larger rather than increasing the height. I think we need to take another screenshot. 😬 I told @reneegranillo that it would be ok to cut off the code wherever we need to as long as createColony
was included.
@collinvine can you clarify your request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, @ryanchristo. People viewing the website should easily be able to read the code.
The included examples are better, but I'd suggest that even they are too small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. If it gets any bigger, we will cut off the createColony
step so we will need to be more specific about what we want to show and whether we want it to show usable code.
42bbc7d
to
9f7e19d
Compare
@ryanchristo The image has been updated to use the larger of the two that you provided. cc @reneegranillo and @collinvine for approval as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me although @reneegranillo and @collinvine should approve as well. I imagine @reneegranillo might want the screenshot to have the same framing as the dApp screenshot.
Also, I would be happy to update the code snippet that we are showing if anyone wants to weigh in on what we should emphasize. I decided to use the code from colonyJS "Get Started" which seemed like the simplest choice at the time but we can change it if we want to show something specific.
Good by me. |
bbdbb75
to
01b7dbc
Compare
Description
Add a collection of style/copy improvements.
Changes 🏗
EtherBanner
paddings / spacing / casingGridItem
forTLDR
sectionAlso closes #127