Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper error handling in EtherRouter #129

Merged
merged 14 commits into from
Dec 13, 2017
Merged

Proper error handling in EtherRouter #129

merged 14 commits into from
Dec 13, 2017

Commits on Dec 12, 2017

  1. Change EtherRouter to use require instead of assert 

    to check the delegate call is successful
    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    bb3716a View commit details
    Browse the repository at this point in the history

  2. Switch to checking for returned revert messages

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    374ad15 View commit details
    Browse the repository at this point in the history

  3. Remove obsolete ifUsingTestRPC helper function

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    a0184d8 View commit details
    Browse the repository at this point in the history

  4. Switch assertRevert helper to accepting a promise

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    5bcce4c View commit details
    Browse the repository at this point in the history

  5. Remove GAS_TO_SPEND constant from most tests 

    As  failures don't consume all gas and so we don't test for it
    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    1fcd7d1 View commit details
    Browse the repository at this point in the history

  6. Cater for parity when checking revert error

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    1c6ff8c View commit details
    Browse the repository at this point in the history

  7. Simplify checkAllGasSpent helper function

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    e01c685 View commit details
    Browse the repository at this point in the history

  8. We can't measure real gas costs in SC so let's not

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    26b1bfb View commit details
    Browse the repository at this point in the history

  9. Consolidate error checking functions

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    0b95566 View commit details
    Browse the repository at this point in the history

  10. Upgrade parity to 1.8.3 beta

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    3cdd8d4 View commit details
    Browse the repository at this point in the history

  11. Add a check for transaction receipt status

    @elenadimitrova
    elenadimitrova committed Dec 12, 2017
    Configuration menu
    Copy the full SHA
    fb415ad View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2017

  1. Remove copyPackages option from solidity-coverage as empty

    @elenadimitrova
    elenadimitrova committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    7fbd0fc View commit details
    Browse the repository at this point in the history

  2. Switch try/catch with helper checkErrorRevert call

    @elenadimitrova
    elenadimitrova committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    ebd40cf View commit details
    Browse the repository at this point in the history

  3. Add a fourth account to parity

    @elenadimitrova
    elenadimitrova committed Dec 13, 2017
    Configuration menu
    Copy the full SHA
    dbae55b View commit details
    Browse the repository at this point in the history