Keep trying to receive websocket notification in test

[AdamISZ]

This may or may not fix #1057 and other test failures. Since the network delay in receiving the message is unknown (but expected to be very small, usually), we keep trying to receive notification of the transaction message in the websocket test 10 times for a total of 2 seconds (on the assumption that if it takes longer than that, something else is wrong).

[AdamISZ]

Seems it still can sometimes fail after 10 tries, on macOS. Perhaps the message is somehow not even being sent over the websocket? Seems unlikely that it's being sent and somehow not arriving for 2 seconds.

As mentioned in #1057 , I'm not sure what I can do since I have no way of reproducing the error.

[AdamISZ]

Also, why are we seeing 2 distinct test runs on each python version? (push, pull request)? Is that just an artifact or is it actually doing 2 runs each time?

[kristapsk]

Also, why are we seeing 2 distinct test runs on each python version? (push, pull request)?

I will look at GitHub Actions, likely our config is wrong. Idea was to run tests both when pull request is open or push to branch happens, not run tests twice on each.

[kristapsk]

Ok, found answer. Reason it runs twice is because you created PR from different branch of the same repo, not from a forked repo (like I usually do). That's why I haven't noticed this myself. But likely we can tweak this.

https://stackoverflow.com/questions/70767090/github-actions-on-push-and-on-pull-request-difference

In general, push will trigger when you push code where pull_request will trigger when there is a pull request.

They overlap when you create PRs from the same repo, but you need pull_request if you want to run an action when you receive a PR from a fork for example. You need push when you want to run an action when something is push. You can fine tune them depending on the behaviour you expect to avoid duplication of jobs.

[AdamISZ]

I see no errors in local testing here, so merging.
What we discuss above is only about stuff happening in CI.