Log in case JM loads RPC wallet at startup #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that's an interesting point; I didn't know that operation could be slow. A comment though, if you want to know how long it takes, doesn't it make sense to do a start/end log (or timer)? because you otherwise only get to know the time between this and the next log message). |
That wasn't my idea, more than for user to know that something happens, but maybe adding additional log at the end will not hurt. This anyway is not something user will see most of the times, when RPC wallet is loaded it stays loaded until you restart bitcoind. |
kristapsk
force-pushed
the
log-loadwallet
branch
from
b38dcbb
to
83d7ebb
Compare
roshii
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some cases when this operation can be slow, better log. Otherwise user might think JM just hanged up.
In my case I was doing some testing on ARM machine where I don't run JM everyday, so that wallet haven't been used for a long time and Core needed to do rescan for almost 8000 blocks.