Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to allow schedule use #447

Closed
wants to merge 1 commit into from
Closed

Conversation

roshii
Copy link
Contributor

@roshii roshii commented Nov 12, 2019

These simple fix allows one to use schedule files with sendpayment.py

@AdamISZ
Copy link
Member

AdamISZ commented Nov 18, 2019

Thanks for the contribution.
I will do some testing in a moment, but, on a first read through, I don't understand the logic: the former version sets the variable mixdepth to the maximum used in the schedule, and then the actual max mixdepth passed into the wallet constructor is the maximum of that, and the options.amtmixdepths ; your new version seems to only read the first entry in the schedule? So it would only work with schedules of length 1? (as opposed to use of a schedule file with the -S option?

@AdamISZ
Copy link
Member

AdamISZ commented Nov 18, 2019

OK, after careful examination I saw that basically one recent PR broke custom schedules, so fixed that. See d9bcca3 .
Sorry for not merging your code but it would have taken much longer to first change it so it made sense, then rebase, then merge the PR than just fix the bug.

@AdamISZ AdamISZ closed this Nov 18, 2019
@roshii
Copy link
Contributor Author

roshii commented Nov 19, 2019

your new version seems to only read the first entry in the schedule? So it would only work with schedules of length 1? (as opposed to use of a schedule file with the -S option?

I wrongly considered that sendpayment.py was meant to send a single payment and as such did not see we it should look further in the file.

No bother for not merging my code, I just did not had the full understanding of script purpose. I'm glad it allowed to fix some issue anyway :)

@roshii roshii deleted the schedule branch November 26, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants