Fix #320573: [MusicXML import] fretboard frets property not saved in …

…MuseScore format Duplicate of musescore#8036, resp. backport of musescore#8037
Jojo-Schmitz · Aug 13, 2021 · 223a4e4 · 223a4e4
1 parent b3fdbfe
commit 223a4e4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/importexport/musicxml/importmxmlpass2.cpp b/importexport/musicxml/importmxmlpass2.cpp
@@ -4906,8 +4906,10 @@ FretDiagram* MusicXMLParserPass2::frame()
       while (_e.readNextStartElement()) {
             if (_e.name() == "frame-frets") {
                   int val = _e.readElementText().toInt();
-                  if (val > 0)
-                        fd->setFrets(val);
+                  if (val > 0) {
+                        fd->setProperty(Pid::FRET_FRETS, val);
+                        fd->setPropertyFlags(Pid::FRET_FRETS, PropertyFlags::UNSTYLED);
+                        }
                   else
                         _logger->logError(QString("FretDiagram::readMusicXML: illegal frame-fret %1").arg(val), &_e);
                   }

diff --git a/mtest/musicxml/io/testChordDiagrams1.xml b/mtest/musicxml/io/testChordDiagrams1.xml
@@ -76,7 +76,7 @@
         <kind>major</kind>
         <frame>
           <frame-strings>6</frame-strings>
-          <frame-frets>5</frame-frets>
+          <frame-frets>3</frame-frets>
           <frame-note>
             <string>5</string>
             <fret>3</fret>