Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for albums #79

Draft
wants to merge 11 commits into
base: 3.x
Choose a base branch
from
Draft

support for albums #79

wants to merge 11 commits into from

Conversation

lyrra
Copy link

@lyrra lyrra commented Sep 9, 2022

Draft, TBD before PR:

  • Would be good to have this tested by others.
  • Also it'd be great to get @SKefalidis' official blessing and review

Current bugs (to be fixed):

  • crash if closing score
  • crash if closing album (in album-manager) FIXED in f184fa8
  • crash if closing album (in album-manager) IF two identical scores are in album
  • crash if "save album" FIXED in 118b96c
  • crash if exiting (seems not related to this PR)
  • Writes album properties in an non-album mscx file

(squashed all of Sergios - Anestis Kefalidis patches (from musescore#6145), and then rebased onto 3.x)
(it compiles almost on mingw, (get undefined reference to `__stack_chk_fail', something with -fstack-protector))
Compiles in a clean build.


fixed currentScoreView updated correctly when switching between excerpts

fixed crash on close album

possible fix-workaround for session restore related crashes

fix paint crash

fix albummanagerdialog with no album loaded

fixed albummanager window calls hide event when changing workspace

drawFrontCover

album title loaded

modified PR musescore#6352

contents pages

fixed crash when adding scores with different instrumentation on new album + playback fix

read + collect_artifacts

enable albumBreaks test

default pause and mass change pause

fixed problems related to restore session? (finally?)

codestyle

use albumScores() instead of x->score

tests for legacy albums

simplified and improved playback control

fixed seq crash

fixed restore session

export parts

at last good playback!!!

fixed crashes related to deleted Album pages

codestyle

cleanup + small things

fix build failure + codestyle

forgot this file

fixed mtests

fixed mtest failure

readme

more cleanup and shorter mtest-scores

forgot this again

correct undo

fixed various issues

updateContents when disabling, crash fixes, drawFrontCover in .msca

disabled Album Manager playback

updated tests

crash fixes

fixed warning + less doLayout calls

fixed parts editing + shadownote for parts

comments

codestyle

rename and comments

a few got left behind

codestyle

rename, delete old code, simplify

codestyle

a bunch of contents and renames

forgot a couple of things

updated text and readme

changed how scores are deleted and forgot this

fix crash by resetting tempScoreTabindex when closing an album

another small fix

fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements

readme

removed text

fixed editing parts and updating the view when editing them

parts scoreview constraints

final touches

readme

codestyle

fix travis failure

FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:
Added tabstops and cleaned ui file, again

text styles for front cover and contents wip

text styles for front cover and contents

fixed rebase

removed unused variable

codestyle

fixed build failure

preferences

@Jojo-Schmitz
Copy link
Owner

Jojo-Schmitz commented Dec 2, 2023

And now a merge conflict to resolve (that file had been removed just now)

@lyrra
Copy link
Author

lyrra commented Dec 2, 2023

2 mtests fail now, apparently on some added tests, should be easy to fix, by adding the corresponding lines

OTOH: why are those needed, if not deviating from the default? IIRC we don't write default values into mscx files

Looking at the surrounding values of other settings, it seems it is writing default values.
What is more worrisome is why we are writing albums key/vals at all in an non-album mscx file.

@Jojo-Schmitz
Copy link
Owner

mtest failures now, crashes actually

@lyrra
Copy link
Author

lyrra commented Jan 24, 2024

mtest failures now, crashes actually

Thanks for the heads-up! pushed fixes (order in style.cpp must be same as in types.h)

SKefalidis and others added 11 commits June 29, 2024 00:45
fixed currentScoreView updated correctly when switching between excerpts

fixed crash on close album

possible fix-workaround for session restore related crashes

fix paint crash

fix albummanagerdialog with no album loaded

fixed albummanager window calls hide event when changing workspace

drawFrontCover

album title loaded

modified PR musescore#6352

contents pages

fixed crash when adding scores with different instrumentation on new album + playback fix

read + collect_artifacts

enable albumBreaks test

default pause and mass change pause

fixed problems related to restore session? (finally?)

codestyle

use albumScores() instead of x->score

tests for legacy albums

simplified and improved playback control

fixed seq crash

fixed restore session

export parts

at last good playback!!!

fixed crashes related to deleted Album pages

codestyle

cleanup + small things

fix build failure + codestyle

forgot this file

fixed mtests

fixed mtest failure

readme

more cleanup and shorter mtest-scores

forgot this again

correct undo

fixed various issues

updateContents when disabling, crash fixes, drawFrontCover in .msca

disabled Album Manager playback

updated tests

crash fixes

fixed warning + less doLayout calls

fixed parts editing + shadownote for parts

comments

codestyle

rename and comments

a few got left behind

codestyle

rename, delete old code, simplify

codestyle

a bunch of contents and renames

forgot a couple of things

updated text and readme

changed how scores are deleted and forgot this

fix crash by resetting tempScoreTabindex when closing an album

another small fix

fix crash when drag&drop with disabled movements, added support for enabling/disabling for parts, various other improvements

readme

removed text

fixed editing parts and updating the view when editing them

parts scoreview constraints

final touches

readme

codestyle

fix travis failure

FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:\
Added tabstops and cleaned ui file, again

text styles for front cover and contents wip

text styles for front cover and contents

fixed rebase

removed unused variable

codestyle

fixed build failure

preferences
not sure if these changes to the reference-scores are
valid, or if the albums-changes are wrongly causing them.
(squash) with patch:
  * albums: mtest musicxml default album-font-sizes
<string notr="true"/>
</property>
<property name="icon">
<iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh?

<string notr="true"/>
</property>
<property name="icon">
<iconset resource="../../../../../../../tmp/QtCreator-FLYAKj/qtc-cmake-rKuWjOTJ/mscore/musescore_qmlcache.qrc">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@Jojo-Schmitz
Copy link
Owner

The mtest reveal that these settings are (expected to be)

      <albumFrontTitleFontSize>10</albumFrontTitleFontSize>
      <albumFrontComposerFontSize>10</albumFrontComposerFontSize>
      <albumFrontLyricistFontSize>10</albumFrontLyricistFontSize>
      <albumContentsTitleFontSize>10</albumContentsTitleFontSize>
      <albumContentsTextFontSize>10</albumContentsTextFontSize>

in the mtest scores.
But as per style.cpp they are 36, 16, 16,24 and 14, repectively. Question now is where that 10 stems from and why.
I don't see wherte and why that happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants