-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work on initial load - Obsidian 1.6.1 #11
Comments
Hope I will find time tomorrow after work. Thanks for the hint with delay/onLayoutReady, should hopefully be a quick fix then 🙏 |
Oh, just saw that 1.6.x is still an insider-build. Since I sadly do not have a paid catalyst license, I cannot work on the issue at this point of time. I will look into it, as soon as 1.6.x is available for me. |
Hi @JonasDoesThings just a note that 1.6.2 was just made public! |
Hi, thanks for the heads-up @luckman212 I sadly could not reproduce the issue, but I added an additional call to the plugin's |
+1,I had the same problem |
I forked and fixed it, very simple patch - @calmwaves111 let me know if that works for you |
Hm, makes sense. My test-vault and my normal vault both don't have these big plugins that take long on startup so that could have been the reason why I couldn't reproduce the issue myself. I have now merged your PR @luckman212 and released a new version 1.4.2 with the changes. I appreciate the help! Thx ❤️ |
@JonasDoesThings awesome, thanks! Another thing I noticed (somewhat related to this bug), is that if the File Explorer is NOT visible when Obsidian is launched (e.g. if you had the Search tab selected instead e.g.) then the folders also fail to get hidden. Looking at the code it seems like that's because the page elements are lazy-loaded and if they aren't visible, then I don't know if there is a hook we can monitor for when the File Explorer first becomes visible but if there is, that would be a better place to hook into than |
A possible workaround: ensure that the File Explorer is shown at startup: app.workspace.ensureSideLeaf('file-explorer', 'left', { active: true }); |
Tested on my fork (works!) New PR: #15 |
New PR: #16 (works for me) |
With the PR being merged & released, I think we can close this now :) |
Since 1.6 (1.6.1 now) the plugin doesn't hide folder at first launch. Probably needs a delay or a wrapping inside of
onLayoutReady()
The text was updated successfully, but these errors were encountered: