Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/restructure vite config package #583

Merged
merged 2 commits into from
Jul 17, 2024
Merged

chore/restructure vite config package #583

merged 2 commits into from
Jul 17, 2024

Conversation

PatrykKuniczak
Copy link
Collaborator

@PatrykKuniczak PatrykKuniczak commented Jul 17, 2024 •
edited
Loading

I think the same structure like other packages could be good, to follow 1 kind of structuring for all packages :)

I have decided also to remove moduleProload prop, because it's true for default
Zrzut ekranu 2024-07-17 111050

Jonghakseo
Jonghakseo approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@Jonghakseo Jonghakseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonghakseo Jonghakseo merged commit ec5c1be into main Jul 17, 2024
5 checks passed
@Jonghakseo Jonghakseo deleted the chore/vite-configs-structure-changes branch July 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonghakseo Jonghakseo Jonghakseo approved these changes

Assignees

@PatrykKuniczak PatrykKuniczak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrykKuniczak @Jonghakseo