Skip to content

Commit

Permalink
Disable tests that (still) require Internet access in the default bui…
Browse files Browse the repository at this point in the history
…ld in the Makefile

test_caching_dns_resolver still requires Internet access. It has a pytest.mark decorator, but "make test" still runs it.

Now "make test" skips this test.

It's probably duplicative with the other tests because the MockedDnsResponseData resolver uses a dns.resolver.Resolver cache internally.

Fixes #128.
  • Loading branch information
JoshData committed Feb 12, 2024
1 parent fd7ed97 commit 306948d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ typing:

.PHONY: test
test:
PYTHONPATH=.:$PYTHONPATH pytest --cov=email_validator
PYTHONPATH=.:$PYTHONPATH pytest --cov=email_validator -k "not network"

.PHONY: testcov
testcov: test
Expand Down

0 comments on commit 306948d

Please sign in to comment.