docs: add unique dependencies rule #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
requested changes
Nov 12, 2024
JoshuaKGoldberg
added
the
status: waiting for author
davidlj95
force-pushed
the
update-unique-dependencies-docs
branch
from
ea0c5a8 to
1e41854
Compare
|
Just seen the eslint CI step failing. Taking a look... 👁️ |
davidlj95
force-pushed
the
update-unique-dependencies-docs
branch
from
1e41854 to
301e2e4
Compare
|
Done! Just noticed that README.md is generated based on the rule description. And hadn't updated that :S Fixed 🔧 |
davidlj95
force-pushed
the
update-unique-dependencies-docs
branch
from
301e2e4 to
30d4a7f
Compare
|
And now saw the formatter was failing too 🙃 Just fixed it. Sorry for the spam 😅 |
|
@all-contributors please add @davidlj95 for doc.
|
|
I've put up a pull request to add @davidlj95! 🎉 |
JoshuaKGoldberg
added a commit
that referenced
this pull request
Nov 12, 2024
Adds @davidlj95 as a contributor for doc. This was requested by JoshuaKGoldberg [in this comment](#620 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
|
🎉 This is included in version v0.16.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
unique-dependenciesdescription in the README is a copy-paste ofvalid-repository-directory#529status: accepting prsOverview
Adds docs for
unique-dependenciesrule