Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: v1.1.x raised engines.node from 16 to 18 #389

Closed
3 tasks done
shiftj18 opened this issue Feb 6, 2024 · 6 comments · Fixed by #390
Closed
3 tasks done

🐛 Bug: v1.1.x raised engines.node from 16 to 18 #389

shiftj18 opened this issue Feb 6, 2024 · 6 comments · Fixed by #390
Labels
type: bug Something isn't working :( 🐛

Comments

@shiftj18
Copy link

shiftj18 commented Feb 6, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The change in the 'engines.node' configuration from 16 to 18 uses the 'x' major version, e.g. 2.0.0.

And, rollback 1.1.0 and 1.2.0.

Actual

image

image

Shouldn't the node version be compatible with the x of the semver rule?

This causes packages or apps using the '^1.0.1' version to abort unexpectedly, when installed using the yarn(v1) package manager in an earlier version of the node environment. Eventually, the installation failed, and the directory 'node_modules' is not exists.

"error ts-api-utils@1.2.0: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.0" error Found incompatible module.'

Additional Info

No response
@shiftj18 shiftj18 added the type: bug Something isn't working :( 🐛 label Feb 6, 2024
@shiftj18
Copy link
Author

shiftj18 commented Feb 6, 2024

image

@aovchinn
Copy link

aovchinn commented Feb 6, 2024

encountered this through typescript-eslint packages, on node 16

@kyle-revio
Copy link

Also ran into this now

@JoshuaKGoldberg
Copy link
Owner

Sorry folks, this is a bug. I'll fix it.

@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: <Why does the new version 1.1.0 not comply with semver about engines.node?> 🐛 Bug: v1.1.x raised engines.node from 16 to 18 Feb 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 6, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Feb 6, 2024
@JoshuaKGoldberg
fix: downgrade engines.node to >=16 (#390)
2857ee9 
## PR Checklist

- [x] Addresses an existing open issue: fixes #389
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Reduces the number in the `package.json` `engines` field.
@JoshuaKGoldberg
Copy link
Owner

Should be fixed in v1.2.1. Sorry for the disruption.

npm i ts-api-utils@latest

@kyle-revio
Copy link

Thanks a million @JoshuaKGoldberg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working :( 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: downgrade engines.node to >=16 JoshuaKGoldberg/ts-api-utils
4 participants
@JoshuaKGoldberg @aovchinn @shiftj18 @kyle-revio