Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Unneeded releases going out #95

Closed
3 tasks done
RebeccaStevens opened this issue Feb 22, 2023 · 4 comments · Fixed by #272
Closed
3 tasks done

🛠 Tooling: Unneeded releases going out #95

RebeccaStevens opened this issue Feb 22, 2023 · 4 comments · Fixed by #272
Labels
area: tooling Managing the repository's maintenance 🛠️ status: needs investigation Further research required...? 🔎

Comments

@RebeccaStevens
Copy link
Collaborator

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

ci: commits seem to trigger releases - they shouldn't

Additional Info

No response
@RebeccaStevens RebeccaStevens added the area: tooling Managing the repository's maintenance 🛠️ label Feb 22, 2023
@RebeccaStevens
Copy link
Collaborator Author

Any particular reason why we're using should-semantic-release and release-it instead of semantic-release?

@JoshuaKGoldberg
Copy link
Owner

semantic-release/semantic-release#2639 😢 I really like semantic-release but they just don't support 0.X versions. Nor are they very actively maintained right now (relative to the amount of user activity).

@RebeccaStevens
Copy link
Collaborator Author

Would it be worth switching over once we release 1.0?

@JoshuaKGoldberg
Copy link
Owner

Ehhhhhhh in theory... but http://github.com/JoshuaKGoldberg/template-typescript-node-package is on release-it still and I'd like to keep the tooling in sync. In theory we should be able to wrestle release-it & co. into submission. If that just can't happen I suppose we can always switch back post-1.0.

@JoshuaKGoldberg JoshuaKGoldberg added the status: needs investigation Further research required...? 🔎 label Mar 8, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 5, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Oct 2, 2023
@JoshuaKGoldberg
build: migrate to create-typescript-app@1 (#272)
8c74729 
## PR Checklist

- [x] Addresses an existing open issue: fixes #95; fixes #270
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/ts-api-utils/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/ts-api-utils/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Looks like this also improves reported unit test coverage? Hooray!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance 🛠️ status: needs investigation Further research required...? 🔎
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: migrate to create-typescript-app@1 JoshuaKGoldberg/ts-api-utils
2 participants
@JoshuaKGoldberg @RebeccaStevens