Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix types for cjs #121

Merged
merged 1 commit into from
Feb 22, 2023
Merged

build: fix types for cjs #121

merged 1 commit into from
Feb 22, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

Add types for cjs.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #121 (2340933) into main (2c5cf36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   21.80%   21.80%           
=======================================
  Files          18       18           
  Lines         431      431           
  Branches      171      171           
=======================================
  Hits           94       94           
  Misses        315      315           
  Partials       22       22           
Flag Coverage Δ
4.2.4 21.11% <ø> (ø)
4.3.5 21.34% <ø> (ø)
4.4.4 21.34% <ø> (ø)
latest 21.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie dokie!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 329ff55 into main Feb 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the cjs-types branch February 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: package is listed as type: module even though it only exports .cjs files
3 participants