-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: setup eslint-plugin-jsdoc to lint jsdoc #157
Conversation
Not sure if we want to enforce We may also want to enforce |
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 21.80% 21.80%
=======================================
Files 18 18
Lines 431 431
Branches 171 171
=======================================
Hits 94 94
Misses 315 315
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested it out locally and got complaints from unnecessary param and returns docs.
Just requesting extending from the recommended ruleset. But if you think that's not best here, then 🚀 let's ship!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Just the one suggestion of a comment to help bump the tracking issue. Ready to merge whenever you'd like to. 🚀
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
PR Checklist
status: accepting prs
Overview
Sets up
eslint-plugin-jsdoc
and apply whitespace fixes for violations reported.