Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup eslint-plugin-jsdoc to lint jsdoc #157

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

PR Checklist

Overview

Sets up eslint-plugin-jsdoc and apply whitespace fixes for violations reported.

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Mar 11, 2023

Not sure if we want to enforce sort-tags.

We may also want to enforce require-jsdoc specifying the contexts to apply in. Here's the config I personally use in my projects for refernce.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #157 (5ee19ab) into main (b85c70a) will not change coverage.
The diff coverage is n/a.

❗ Current head 5ee19ab differs from pull request most recent head 6f69f41. Consider uploading reports for the commit 6f69f41 to get more accurate results

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   21.80%   21.80%           
=======================================
  Files          18       18           
  Lines         431      431           
  Branches      171      171           
=======================================
  Hits           94       94           
  Misses        315      315           
  Partials       22       22           
Flag Coverage Δ
4.2.4 21.11% <ø> (ø)
4.3.5 21.34% <ø> (ø)
4.4.4 21.34% <ø> (ø)
latest 21.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/comments.ts 0.00% <ø> (ø)
src/compilerOptions.ts 84.21% <ø> (ø)
src/flags.ts 100.00% <ø> (ø)
src/modifiers.ts 0.00% <ø> (ø)
src/nodes/typeGuards/compound.ts 40.90% <ø> (ø)
src/nodes/typeGuards/single.ts 0.00% <ø> (ø)
src/nodes/typeGuards/union.ts 1.94% <ø> (ø)
src/scopes.ts 0.00% <ø> (ø)
src/syntax.ts 91.66% <ø> (ø)
src/tokens.ts 0.00% <ø> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested it out locally and got complaints from unnecessary param and returns docs.

Just requesting extending from the recommended ruleset. But if you think that's not best here, then 🚀 let's ship!

.eslintrc.cjs Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Mar 11, 2023
@RebeccaStevens RebeccaStevens removed the status: waiting for author Needs an action taken by the original poster label Mar 12, 2023
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just the one suggestion of a comment to help bump the tracking issue. Ready to merge whenever you'd like to. 🚀

.eslintrc.cjs Show resolved Hide resolved
RebeccaStevens and others added 2 commits March 13, 2023 13:34
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Add linting to prevent blank/redundant JSDoc/TSDoc tags
2 participants