-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve the release docs workflow #254
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 35 35
Lines 6406 6406
Branches 360 360
=======================================
Hits 5139 5139
Misses 1267 1267
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hmm, not sure if there's a nice way to ignore those spelling issues other than just adding the detected words to the cspell dictionary. |
29cb68b
to
c63dd32
Compare
Pushed a new update that rework the docs workflows a bit. They aren't fully tested as testing workflows is hard, but hopefully they work as intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! This is getting a bit complicated and long term I think it'd be nice to extract the logic out into its own reusable workflows. But for now it feels reasonable to just go with it. Thanks!
👋 ping @RebeccaStevens, is this something you're interested in and have time for? |
What's the status of this? What needs doing? |
I'd left a few questions for you in comment threads. I'm up for merging as-is with the suggested touchups, but didn't want to steamroll past you. 🙂 |
332582f
to
811692a
Compare
use npx instead
old docs will now be handled correctly
811692a
to
30324b9
Compare
I've rebased this off #341 and made a few updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! Let's give this a shot. 🚀
PR Checklist
status: accepting prs
Overview
The same issue as RebeccaStevens/uom-types#55
Before Merge
gh-pages
branch need to be created. Create with:git switch --orphan gh-pages git commit --allow-empty -m "initial docs" --no-verify git push