-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs to functions and setup auto-generation of docs #70
Conversation
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 21.99% 21.99%
=======================================
Files 18 18
Lines 432 432
Branches 171 171
=======================================
Hits 95 95
Misses 315 315
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 @RebeccaStevens this is fantastic, thanks for sending it in! The site works great and I like the deployment strategy a lot. Also strong +1 to a lot of the customizations in typedoc.json
Mostly requesting changes around removing redundant tags & filling in some more site info.
"typedoc-plugin-versions" | ||
], | ||
"readme": "none" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Comment] I have a few miscellaneous feature requests that are definitely not blocking for this PR and probably shouldn't go in it even if they're immediately actionable:
- Integrating Konamimojisplosion 😁
- Adding a Ctrl/Cmd+K shortcut for search the way Docusaurus and a lot of other sites / site generators have
- Adding lint rules around tags: avoiding blank/redundant ones and including useful on exported things
...just posting here so I don't forget them.
path: docs/ | ||
|
||
- name: Deploy to GitHub Pages | ||
uses: actions/deploy-pages@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Praise] This is a great .yml
file, thank you 😄. I've been meaning to look into GH page deployments for OpenContributionsProject/opencontributionssite#29...
cc @blackgirlbytes, good timing here!
ffef6e6
to
2d499fd
Compare
2d499fd
to
c565399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️🔥 awesome! Really excited to get this in.
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 This is fantastic, thanks so much @RebeccaStevens! I learned a bunch of things from this PR 😄.
Ready to merge whenever you're happy. 🚀
I can't guarantee that the workflow is completely correct. We might have to debug it once this is merged. |
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
I can't merge this due to unresolved conversations. I'll resolve them then unresolve them so I can merge this. |
PR Checklist
status: accepting prs
Overview