SVG maintenance #704
Merged
SVG maintenance #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drillprop
commented
Jun 2, 2021
| + 'mask-type', | ||
| 'height', | ||
| 'maskUnits', | ||
| 'maskContentUnits' |
There was a problem hiding this comment.
Had to add this. SVGR using the old version of the SVGO package, which is removing mask-type from attributes gregberge/svgr#336. Some of our SVGs have this attribute(e.g. transaction illustration, avatar silhouette) and it's needed to properly display them
drillprop
commented
Jun 2, 2021
| @@ -7,6 +7,9 @@ module.exports = { | |||
| typescript: true, | |||
| svgo: true, | |||
| prettier: true, | |||
| svgoConfig: { | |||
| plugins: [{ removeViewBox: false }], | |||
| }, | |||
There was a problem hiding this comment.
Decided to add this. Some illustrations, for example empty-state-illustration.svg was not displayed correctly on smaller devices. I think we should apply this plugin to all of our SVGs. You can read why here
mikkio-j
approved these changes
Jun 4, 2021
kdembler
approved these changes
Jun 4, 2021
kdembler
added a commit
that referenced
this pull request
Jun 9, 2021
* move assets to shared folder * update svgr config, add new codegen scripts * patch svgo, generate new svg components * Update package.json Co-authored-by: Klaudiusz Dembler <accounts@kdembler.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #583