Merge pull request #140 from theirishpenguin/penguin/issue-135-handle…

…-not-authorized Handle 401 Not Authorized Response
JsonApiClient · Nov 16, 2015 · 6bbdc61 · 6bbdc61
2 parents ceae78b + 235922e
commit 6bbdc61
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/lib/json_api_client/errors.rb b/lib/json_api_client/errors.rb
@@ -13,6 +13,9 @@ class ClientError < ApiError
     class AccessDenied < ClientError
     end
 
+    class NotAuthorized < ClientError
+    end
+
     class ConnectionError < ApiError
     end
 

diff --git a/lib/json_api_client/middleware/status.rb b/lib/json_api_client/middleware/status.rb
@@ -20,6 +20,8 @@ def call(environment)
       def handle_status(code, env)
         case code
         when 200..399
+        when 401
+          raise Errors::NotAuthorized, env
         when 403
           raise Errors::AccessDenied, env
         when 404

diff --git a/test/unit/errors_test.rb b/test/unit/errors_test.rb
@@ -47,6 +47,15 @@ def test_access_denied
     end
   end
 
+  def test_access_denied
+    stub_request(:get, "http://example.com/users")
+      .to_return(headers: {content_type: "text/plain"}, status: 401, body: "not authorized")
+
+    assert_raises JsonApiClient::Errors::NotAuthorized do
+      User.all
+    end
+  end
+
   def test_errors_are_rescuable_by_default_rescue
     begin
       raise JsonApiClient::Errors::ApiError, "Something bad happened"