Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing constant formatter #357

Merged
merged 1 commit into from
Aug 29, 2019
Merged

fix missing constant formatter #357

merged 1 commit into from
Aug 29, 2019

Conversation

senid231
Copy link
Member

fixes #333

I think we can just require formatter.rb instead of auto load it. It will fix all problems with missing contant

@senid231 senid231 requested a review from gaorlov August 18, 2019 13:05
@senid231 senid231 self-assigned this Aug 18, 2019
gaorlov
gaorlov reviewed Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@gaorlov gaorlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking the time. Can you update the changelog?

@senid231 senid231 force-pushed the fix-missing-constant-formatter branch from a688d83 to af722c5 Compare August 28, 2019 11:25
@senid231
Copy link
Member Author

@gaorlov done

@gaorlov
Copy link
Collaborator

gaorlov commented Aug 28, 2019

Thanks! I'll ship it by EOD

@gaorlov gaorlov merged commit 4aa0814 into JsonApiClient:master Aug 29, 2019
@gaorlov
Copy link
Collaborator

gaorlov commented Aug 29, 2019

1.15.0 is now live

@kamal
Copy link

kamal commented Aug 29, 2019

@gaorlov https://github.com/JsonApiClient/json_api_client/blob/master/lib/json_api_client/version.rb still shows 1.14.1

@gaorlov
Copy link
Collaborator

gaorlov commented Aug 29, 2019

@kamal fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaorlov gaorlov gaorlov left review comments

Assignees

@senid231 senid231

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing constant error in puma
3 participants
@senid231 @gaorlov @kamal