Support gzip content encoding #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaorlov Hi again ) Is there a chance to merge this? ) |
stokarenko
force-pushed
the
gzip-support
branch
from
1e5cb96
to
bc8fc09
Compare
|
Absolutely! I'll have it out by end of day tomorrow! Thanks for the work! |
|
FYI regarding to server side - default router (dokku, k8s etc) will not Gzip JSON-API responses because of custom |
|
Probably we can add this hint in readme ) |
gaorlov
approved these changes
Sep 24, 2019
|
@stokarenko |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing special, just adding
::FaradayMiddleware::GzipFaraday middleware in order to take an advantage of Gzipped response body )