Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra error classes to handle server errors. #382

Merged
merged 4 commits into from
Aug 19, 2021

Conversation

emancu
Copy link
Contributor

@emancu emancu commented May 6, 2021

In order to provide more granularity on the exceptions, we are adding some additional error classes for the common Server errors.

We also fixed the hierarchy for some client errors that were listed as server errors.

In order to provide more granularity on the exceptions, we are adding some additional
error classes for the common Server errors.
lib/json_api_client/errors.rb Outdated Show resolved Hide resolved
@gaorlov
Copy link
Collaborator

gaorlov commented Aug 18, 2021

This is great! Can you please update the changelog md?
Thanks for taking the time!

emancu and others added 2 commits August 18, 2021 23:14
Co-authored-by: Tilo <tilo@users.noreply.github.com>
@emancu
Copy link
Contributor Author

emancu commented Aug 18, 2021

@gaorlov done!

@gaorlov gaorlov merged commit 3e801e1 into JsonApiClient:master Aug 19, 2021
@gaorlov
Copy link
Collaborator

gaorlov commented Aug 19, 2021

1.19.0 is now live with your changes. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants