Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-tidy version #92

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update clang-tidy version #92

wants to merge 6 commits into from

Conversation

chraibi
Copy link
Member

@chraibi chraibi commented Oct 24, 2021

  • clang-tidy version = 13
  • minor readme modifications
  • minor changes in the contribution guide

@chraibi chraibi mentioned this pull request Oct 24, 2021
zeroset
zeroset previously approved these changes Oct 25, 2021
README.md Outdated

```
```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not bash, should we just use code block without language, or is this a syntax error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should specify the language. So, I just went with bash. Have a better suggestion?

Copy link
Contributor

@Ozaq Ozaq Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct language identification would be text according to the GitHub doc, at least when it is rendered online. Other markdown renderers might not know that language identifier, but text is like a no-op anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants