Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async workaround for Chromium bug #55

Closed
tomalec opened this issue Apr 17, 2018 · 0 comments
Closed

Remove async workaround for Chromium bug #55

tomalec opened this issue Apr 17, 2018 · 0 comments
Assignees

Comments

@tomalec
Copy link
Member

tomalec commented Apr 17, 2018

We have quite an old workaround for Polymer/polymer#554, http://crbug.com/389566
https://github.com/Juicy/imported-template/blob/master/imported-template.html#L91-L99

Even though https://bugs.chromium.org/p/chromium/issues/detail?id=521692&desc=2 is still opened, use case closer to us webcomponents/webcomponentsjs#480 (comment) seems to be solved.

This workaround introduces yet another leyer of asynchronity, that may introduce potentially FOUC.

I think we could consider making imported-template testcase based on http://tomalec.github.io/templates_vs_htmlimports-issue/, http://jsbin.com/cizeviq/edit?html,console,output, https://bugs.chromium.org/p/chromium/issues/attachmentText?aid=127035
Then removing this hack.

tomalec added a commit that referenced this issue Aug 22, 2018
tomalec added a commit that referenced this issue Aug 28, 2018
Add test-case and remove workaround for fixed chromium bug,
tomalec added a commit to Starcounter/StarcounterClientFiles that referenced this issue Aug 29, 2018
Removes chromium bug workaround Juicy/imported-template#55,
makes the flow more synchronous,
reduces the reasons of FOUC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant