Dispatch stamped event as Juicy/juicy-html does
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warpech
reviewed
Oct 9, 2017
README.md
Outdated
| @@ -114,6 +114,7 @@ To provide a state before element is upgraded, please use attributes. | |||
|
|
|||
| Name | Detail | Description | |||
| --- | --- | --- | |||
| `stamped` | *Array* of *Node* s array of stamped nodes | Trigger every time content is (re-)stamped | |||
There was a problem hiding this comment.
Shouldnt' detail be *Array* of *Node* s like in juicy-html?
There was a problem hiding this comment.
I don't get it. It is "Array of Nodes".
There was a problem hiding this comment.
I can see some redundant text in that column. See the highlight on the below screenshot:
There was a problem hiding this comment.
ah! So you want to remove "array of stamped nodes"?
There was a problem hiding this comment.
Yes, or move the description of the detail to the description column
There was a problem hiding this comment.
I gave it a second thought, I would say we need two descriptions: one to describe when the event is fired, another to describe the detail contents.
What about:
| Name | Detail | When |
|---|---|---|
stamped |
Array of stamped Node s | Every time content is (re-)stamped |
or
| Name | When | Detail |
|---|---|---|
stamped |
Every time content is (re-)stamped | Array(Node) - stamped nodes |
|
Setting as “Finished” because it is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need tests for this, but they should be added in
juicy-htmlrepo first Juicy/juicy-html#33