Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pending flag resetting #33

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Fix pending flag resetting #33

merged 1 commit into from
Nov 29, 2017

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented Oct 6, 2017

So far we have no tests for pending and I'm not sure whether it should be public API.

However, right now it's polluting link element, as it's setting .pending property on it.

@tomalec tomalec added the bug label Oct 6, 2017
@warpech
Copy link
Contributor

warpech commented Oct 9, 2017

It would be good to add a test though.

@tomalec
Copy link
Member Author

tomalec commented Nov 29, 2017 •
edited
Loading

I created a separate issue for it in juicy-html Juicy/juicy-html#36

@tomalec tomalec merged commit 963b773 into master Nov 29, 2017
@tomalec tomalec deleted the pending-reset branch December 12, 2017 23:32
@warpech
Copy link
Contributor

warpech commented Jan 9, 2018

Setting as “Finished” because it is:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warpech warpech warpech approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomalec @warpech