Compatibility fix for hybrid views for Polymer 1 and 2 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is="dom-bind"> if it is wrapped in <dom-bind>. This makes it impossible to have hybrid views for Polymer 1 and 2 Solution: apply the mirrored version of the Polymer's own solution for this problem: https://github.com/Polymer/polymer/pull/4537/files
tomalec
reviewed
Dec 19, 2017
There was a problem hiding this comment.
Same as Juicy/juicy-html#37 (comment), other than that LGTM
alshakero
approved these changes
Dec 19, 2017
|
Setting as “Finished” because it is:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
imported-templatedoes not forward notifications to<template is="dom-bind">if it is wrapped in<dom-bind>. This makes it impossible to have hybrid views for Polymer 1 and 2Solution: apply the mirrored version of the Polymer's own solution for this problem: https://github.com/Polymer/polymer/pull/4537/files
This was discussed in starcounter.slack.com/archives/C5PEXSXQE/p1513614571000221
Requires Juicy/juicy-html#37, otherwise the tests fail.