Workaround HTML Imports bug that blocks imported link rel="stylesheet"s in IE/Edge,
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t"`s in IE/Edge, Remove `type="import-disable"` attribute of stamped links, clean all templates recursively, https://github.com/webcomponents/webcomponentsjs/issues/1008 https://github.com/Starcounter/uniform.css/issues/63
alshakero
approved these changes
Sep 18, 2018
imported-template.html
Outdated
| @@ -54,6 +64,9 @@ | |||
| singleTemplate = templates[nodeNo]; | |||
| //d debugger // or innerHTML in this case | |||
| singleFragment = document.importNode(singleTemplate.content, true); | |||
| if(isIE){ | |||
| stripDisabledType(singleFragment); | |||
| } | |||
| // convert dynamic NodeList to regullar array | |||
| nodes = Array.prototype.slice.call(singleFragment.childNodes); | |||
There was a problem hiding this comment.
regullar -> regular.
Isn't Array.from cleaner?
| @@ -0,0 +1,3 @@ | |||
| #green{ | |||
| color: rgb(0, 128, 0); | |||
There was a problem hiding this comment.
I would use a different value (than the other stylesheet) for easier debugging in case we needed that.
instead of `Array.prototype.slice.call`, as suggested at #59 (comment)
as suggested at #59 (comment)
tomalec
force-pushed
the
Starcounter/uniform.css/issues/63-add-workaround-for-HTMLImports-bug
branch
from
54932e2
to
306cbe1
Compare
tomalec
added a commit
to Starcounter/starcounter-include
that referenced
this pull request
Sep 18, 2018
to emphasize the need for Juicy/imported-template#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
type="import-disable"attribute of stamped links, clean all templates recursively,https://github.com/webcomponents/webcomponentsjs/issues/1008
https://github.com/Starcounter/uniform.css/issues/63