Remove heatmapping functionality #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move heatmapping on `Explanation` type to VisionHeatmaps.jl and TextHeatmaps.jl via package extensions on XAIBase.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
- Coverage 97.80% 97.01% -0.79%
==========================================
Files 8 7 -1
Lines 91 67 -24
==========================================
- Hits 89 65 -24
Misses 2 2 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 19, 2024
adrhill
added a commit
to Julia-XAI/TextHeatmaps.jl
that referenced
this pull request
Feb 19, 2024
Continues work started in Julia-XAI/XAIBase.jl#16 and Julia-XAI/VisionHeatmaps.jl#7 by moving `heatmap` methods on `Explanation` type to TextHeatmaps.jl via package extensions on XAIBase.
adrhill
added a commit
to Julia-XAI/VisionHeatmaps.jl
that referenced
this pull request
Feb 19, 2024
Continues work started in Julia-XAI/XAIBase.jl#16 by moving `heatmap` methods on `Explanation` type to VisionHeatmaps.jl via package extensions on XAIBase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move heatmap methods on
Explanationtype to VisionHeatmaps.jl and TextHeatmaps.jl via package extensions on XAIBase.This makes things more modular and easier to maintain:
This change is breaking: users are now required to manually load either VisionHeatmaps or TextHeatmaps.