Use "algorithm" instead of "model" and dispatch predict
on kind of target proxy
#17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12 and #14.
In this PR:
predict_joint
method, as redundant under changes belowTargetProxy
abstract type is renamedKindOfProxy
predict
for target variable or target proxy only (transform
is for anything else) and add argument topredict
to allow dispatch on the kind of target proxy. In this way algorithms can implement predict for multiple kinds of target proxy, although we now require declaration of a preferred kind (newpreferred_kind_of_proxy
trait).inverse_transform
; I figure these can just be inferred from thetransform
traits.