Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairing with mlflow release api definition #59

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Nov 3, 2024

This PR contains a major update in the project.

  • New project structure to ensure better maintainability.
  • Adopting Blue Style to improve readability.
  • Pair with all the types from mlflow REST API.
  • Implement all the endpoints from mlflow latest release.
  • Improved documentation with multiple dispatch definitions.
  • Simplify function definitions.
  • Simplify test definitions.

Important

This update comes with some breaking changes. Projects like MLJFlow.jl will need to update carefully. It will be the same with personal projects.

TODO list:

  • Implementing RegisteredModel and ModelVersion operations.
    • RegisteredModel
    • ModelVersion
  • Implementing mlflow authentication REST API operations.
  • Implementing hidden artifact REST API operations (See Allow logging to remote artifact location #55).

Useful links:

@pebeto pebeto added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 3, 2024
@pebeto pebeto self-assigned this Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 86.81818% with 29 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (a31b41a) to head (e033c9a).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/types/run.jl 66.66% 6 Missing ⚠️
src/api.jl 73.33% 4 Missing ⚠️
src/services/run.jl 89.47% 4 Missing ⚠️
src/utils.jl 94.82% 3 Missing ⚠️
src/types/dataset.jl 66.66% 2 Missing ⚠️
src/types/registered_model.jl 0.00% 2 Missing ⚠️
src/services/experiment.jl 97.36% 1 Missing ⚠️
src/services/loggers.jl 95.00% 1 Missing ⚠️
src/services/misc.jl 85.71% 1 Missing ⚠️
src/types/artifact.jl 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   78.07%   87.01%   +8.93%     
==========================================
  Files          10       17       +7     
  Lines         333      231     -102     
==========================================
- Hits          260      201      -59     
+ Misses         73       30      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pebeto pebeto force-pushed the pairing_with_mlflow_release_api_definition branch 2 times, most recently from 7522838 to 50004ce Compare November 3, 2024 09:47
@pebeto
Copy link
Member Author

pebeto commented Nov 3, 2024

Changing LTS pipeline version to 1.10 (See JuliaAI/MLJ.jl#1143).

@pebeto pebeto mentioned this pull request Nov 3, 2024
@ablaom
Copy link
Member

ablaom commented Nov 3, 2024

@pebeto Thanks for what looks like a considerable effort 🎉

Unfortunately, I don't really have the bandwidth to review PRs at MLFlowClient, and was never really that familiar with this side of things. (Still happy to review at MLJFlow.jl). Perhaps see if one of the other recent contributors would care to review.

I see there is still a to-do list. Perhaps you want to flag this as a "Draft", unless you are seeking a review already?

@pebeto pebeto marked this pull request as draft November 4, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants