Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: split the integration tests into a separate job #1086

Merged
merged 1 commit into from
Jan 16, 2024
Merged

CI: split the integration tests into a separate job #1086

merged 1 commit into from
Jan 16, 2024

Conversation

DilumAluthge
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7358186) 57.89% compared to head (0901985) 57.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1086   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files           2        2           
  Lines          38       38           
=======================================
  Hits           22       22           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge marked this pull request as ready for review January 16, 2024 05:29
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jan 16, 2024

@ablaom I think this approach makes it a bit easier to figure out (at a quick glance) whether or not the integration tests ran. Instead of having to look at the wall time of a job (and using the wall time to guess whether or not the integration tests ran), with this approach, if the integration tests don't run, they are marked as "Skipped" in GitHub, and they show up as a gray icon.

@ablaom
Copy link
Member

ablaom commented Jan 16, 2024

This is a great idea!

If I understand this, in the dev -> master case we do run the non-integration tests twice (although in parallel jobs). I don't think this matters as these tests are pretty trivial. MLJ just collects other packages together, so there isn't much MLJ-specific testing.

@ablaom ablaom merged commit 51ed76e into JuliaAI:dev Jan 16, 2024
3 checks passed
@ablaom ablaom mentioned this pull request Jan 16, 2024
@DilumAluthge DilumAluthge deleted the dpa/integration-tests branch January 16, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants