Merge pull request #913 from JuliaAI/remove-redundant-params

Remove some orphaned code
JuliaAI · Jul 4, 2023 · 29a6ef0 · 29a6ef0
2 parents e151fe1 + 5b549f9
commit 29a6ef0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 37 deletions.
diff --git a/src/MLJBase.jl b/src/MLJBase.jl
@@ -292,11 +292,15 @@ export coerce, coerce!, autotype, schema, info
 export UnivariateFiniteArray, UnivariateFiniteVector
 
 # -----------------------------------------------------------------------
-# abstract model types defined in MLJModelInterface.jl and extended here:
+# re-export from MLJModelInterface.jl
+
+#abstract model types defined in MLJModelInterface.jl and extended here:
 for T in EXTENDED_ABSTRACT_MODEL_TYPES
     @eval(export $T)
 end
 
+export params
+
 # -------------------------------------------------------------------
 # exports from this module, MLJBase
 
@@ -306,9 +310,6 @@ export default_resource
 # one_dimensional_ranges.jl:
 export ParamRange, NumericRange, NominalRange, iterator, scale
 
-# parameter_inspection.jl:
-export params # note this is *not* an extension of StatsBase.params
-
 # data.jl:
 export partition, unpack, complement, restrict, corestrict
 

diff --git a/src/parameter_inspection.jl b/src/parameter_inspection.jl