Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some orphaned code #913

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Remove some orphaned code #913

merged 1 commit into from
Jul 4, 2023

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jul 4, 2023

To mitigate some understandable confusion, this removes some code that is not included by MLJBase.jl, and so redundant.

cc @pabeto

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #913 (5b549f9) into dev (93cd92e) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #913      +/-   ##
==========================================
+ Coverage   87.59%   87.76%   +0.16%     
==========================================
  Files          41       40       -1     
  Lines        3660     3653       -7     
==========================================
  Hits         3206     3206              
+ Misses        454      447       -7     
Impacted Files Coverage Δ
src/MLJBase.jl 100.00% <ø> (ø)

@ablaom ablaom merged commit 29a6ef0 into dev Jul 4, 2023
3 checks passed
@ablaom ablaom deleted the remove-redundant-params branch July 4, 2023 09:30
@ablaom ablaom restored the remove-redundant-params branch July 19, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants