Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle init correctly in kmeans #21

Merged
merged 3 commits into from
Sep 8, 2022
Merged

handle init correctly in kmeans #21

merged 3 commits into from
Sep 8, 2022

Conversation

jbrea
Copy link
Collaborator

@jbrea jbrea commented Sep 7, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #21 (9167294) into master (1cb5d10) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files           1        1           
  Lines          76       76           
=======================================
  Hits           73       73           
  Misses          3        3           
Impacted Files Coverage Δ
src/MLJClusteringInterface.jl 96.05% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. Could you please add init to KMedoids as well 🙏🏾 . The seeding options are the same; only "initial cluster centers" becomes "initial medoids" in the doc-string.

Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
@jbrea
Copy link
Collaborator Author

jbrea commented Sep 8, 2022

Done.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Thanks @jbrea for this valuable contribution.

@ablaom ablaom merged commit 81d5609 into JuliaAI:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants