-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing test URI to the defined ENV variable #30
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #30 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 4 4
Lines 45 45
=======================================
Hits 44 44
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Thanks @pebeto for returning to this. This now works for me locally: I launch an mlflow service on my mac, set The error I get if I don't set the env variable is not too helpful. But this is hard to fix completely, because there could be other sources for the error. Perhaps we could improve the error message issued here. Something like: error("It seems that the MLFlow server is not running at specified "*
"location, $baseuri. For more information, see https://mlflow.org/docs/latest/quickstart.html") which adds a reference to the failing Another problem I noticed is this warning:
I believe this is fixed by replacing this line with: function log_evaluation(logger::Logger, performance_evaluation) Otherwise the overloading is not specialising to MLFlow.Logger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. You can stop codecov being so fussy by adding a /.github/codecov.yml configuration like this one: https://github.com/JuliaAI/CategoricalDistributions.jl/blob/dev/.github/codecov.yml
As defined in #20
Closes #20