Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing test URI to the defined ENV variable #30

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

pebeto
Copy link
Member

@pebeto pebeto commented Nov 18, 2023

As defined in #20
Closes #20

@pebeto pebeto linked an issue Nov 18, 2023 that may be closed by this pull request
@pebeto pebeto requested a review from ablaom November 18, 2023 18:50
@pebeto pebeto self-assigned this Nov 18, 2023
@pebeto pebeto added the enhancement New feature or request label Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5aebc7c) 97.77% compared to head (d7658cb) 97.77%.

Files Patch % Lines
src/types.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #30   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           4        4           
  Lines          45       45           
=======================================
  Hits           44       44           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Member

ablaom commented Nov 20, 2023

Thanks @pebeto for returning to this. This now works for me locally: I launch an mlflow service on my mac, set MLFLOW_URI="http://127.0.0.1:5000" and tests run successfully!

The error I get if I don't set the env variable is not too helpful. But this is hard to fix completely, because there could be other sources for the error. Perhaps we could improve the error message issued here. Something like:

 error("It seems that the MLFlow server is not running at specified "*   
           "location, $baseuri. For more information, see https://mlflow.org/docs/latest/quickstart.html")

which adds a reference to the failing baseuri.

Another problem I noticed is this warning:

│  WARNING: Method definition log_evaluation(Any, Any) in module MLJBase at /Users/anthony/.julia/packages/MLJBase/fEiP2/src/resampling.jl:866 overwritten in module MLJFlow at /Users/anthony/MLJ/MLJFlow/src/base.jl:1.
│    ** incremental compilation may be fatally broken for this module **

I believe this is fixed by replacing this line with:

function log_evaluation(logger::Logger, performance_evaluation)

Otherwise the overloading is not specialising to MLFlow.Logger.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You can stop codecov being so fussy by adding a /.github/codecov.yml configuration like this one: https://github.com/JuliaAI/CategoricalDistributions.jl/blob/dev/.github/codecov.yml

@ablaom ablaom merged commit 9eac9ae into dev Nov 20, 2023
3 of 4 checks passed
This was referenced Nov 20, 2023
@pebeto pebeto deleted the 20-improve-local-testability branch May 21, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve local testability
2 participants