Skip to content
This repository has been archived by the owner on Jun 22, 2021. It is now read-only.

Make scitype efficient for views of CategoricalArrays #78

Closed
ablaom opened this issue May 31, 2021 · 0 comments · Fixed by #80
Closed

Make scitype efficient for views of CategoricalArrays #78

ablaom opened this issue May 31, 2021 · 0 comments · Fixed by #80

Comments

@ablaom
Copy link
Member

ablaom commented May 31, 2021

This code makes scitype avoid calling expensive type unions over elements in the case of CategoricalArray's. However, it does not catch views of CategoricalArrays. So the type in the method referenced needs to be broadened.

To include views of CategoricalArrays (which are not categorical arrays) is a bit awkward, but here's the latest authority on how to do this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant