Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat Fix for Versioning #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TheCedarPrince
Copy link
Member

PR Checklist

If you are contributing to JavisNB.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add JavisNB dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)

N/A

How did you address these issues with this PR? What methods did you use?

Saw that the docs still had a bug.
Fixed it by removing the compat for Javis.
Until Javis 0.8.0 is released, there will still be issues but then we can register Javis and formally announce the release of JavisNB

@Wikunia
Copy link
Member

Wikunia commented Jan 29, 2022

Why don't we need a compat entry for Javis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants